Opts: Solve OptionsParser::Exception diamond inheritance problem

2026-04-02 01:28:37 -04:00
parent 3f2d7c24ee
commit 06996d166e
2 changed files with 19 additions and 21 deletions
@@ -10,28 +10,28 @@
 #include <spinscale/callableTracer.h>


+OptionParser::Exception::Exception(std::string message_)
+: message(std::move(message_))
+{
+}
+
+const char* OptionParser::Exception::what() const noexcept
+{
+    return message.c_str();
+}
+
 OptionsParserError::OptionsParserError(
    const std::string& errorMessage, const OptionParser& parser
 )
-: std::invalid_argument(errorMessage + "\n" + parser.getUsage())
+: OptionParser::Exception(errorMessage + "\n" + parser.getUsage())
 {
 }

-const char* OptionsParserError::what() const noexcept
-{
-    return std::invalid_argument::what();
-}
-
 JustPrintUsageNoError::JustPrintUsageNoError(const OptionParser& parser)
-: message(parser.getUsage())
+: OptionParser::Exception(parser.getUsage())
 {
 }

-const char* JustPrintUsageNoError::what() const noexcept
-{
-    return message.c_str();
-}
-
 struct option OptionParser::longOptions[] = {
    {"dapspec", required_argument, 0, 's'},
    {"spec", required_argument, 0, 's'},