Get rid of rvalue ref returns
This commit is contained in:
@@ -133,7 +133,7 @@ public:
|
||||
* @param dontAcquireLock If true, skips acquiring the internal spinlock
|
||||
* (assumes caller already holds it)
|
||||
*/
|
||||
[[nodiscard]] std::unique_ptr<DependencyGraph>&& generateGraph(
|
||||
[[nodiscard]] std::unique_ptr<DependencyGraph> generateGraph(
|
||||
bool dontAcquireLock = false);
|
||||
|
||||
// Disable copy constructor and assignment operator
|
||||
|
||||
@@ -39,7 +39,7 @@ public:
|
||||
|
||||
// Return list of all qutexes in predecessors' LockSets; excludes self.
|
||||
[[nodiscard]]
|
||||
std::unique_ptr<std::forward_list<std::reference_wrapper<Qutex>>>&&
|
||||
std::unique_ptr<std::forward_list<std::reference_wrapper<Qutex>>>
|
||||
getAcquiredQutexHistory() const;
|
||||
|
||||
public:
|
||||
|
||||
@@ -114,7 +114,7 @@ void DependencyGraph::dfsCycleDetection(
|
||||
}
|
||||
|
||||
// QutexAcquisitionHistoryTracker implementation
|
||||
std::unique_ptr<DependencyGraph>&&
|
||||
std::unique_ptr<DependencyGraph>
|
||||
QutexAcquisitionHistoryTracker::generateGraph(bool dontAcquireLock)
|
||||
{
|
||||
auto graph = std::make_unique<DependencyGraph>();
|
||||
@@ -169,7 +169,7 @@ QutexAcquisitionHistoryTracker::generateGraph(bool dontAcquireLock)
|
||||
acquisitionHistoryLock.release();
|
||||
}
|
||||
|
||||
return std::move(graph);
|
||||
return graph;
|
||||
}
|
||||
|
||||
/** EXPLANATION - GRIDLOCK DETECTION ALGORITHM:
|
||||
|
||||
@@ -198,7 +198,7 @@ SerializedAsynchronousContinuation<OriginalCbFnT>
|
||||
#endif
|
||||
|
||||
template <class OriginalCbFnT>
|
||||
std::unique_ptr<std::forward_list<std::reference_wrapper<Qutex>>>&&
|
||||
std::unique_ptr<std::forward_list<std::reference_wrapper<Qutex>>>
|
||||
SerializedAsynchronousContinuation<OriginalCbFnT>::getAcquiredQutexHistory()
|
||||
const
|
||||
{
|
||||
@@ -229,7 +229,7 @@ const
|
||||
}
|
||||
}
|
||||
|
||||
return std::move(heldLocks);
|
||||
return heldLocks;
|
||||
}
|
||||
|
||||
// Explicit template instantiations for the types we need
|
||||
|
||||
Reference in New Issue
Block a user