hayodea/salmanoff
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

LivoxProto1:enPcloudData: reorder success case here

Browse Source
This commit is contained in:
Hayodea Hekol
2025-10-24 01:46:08 -04:00
parent 2b8f6b6ad5
commit 4bfcdf37da
1 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
commonLibs/livoxProto1/device.cpp
+13 -8
View File
@@ -1533,19 +1533,24 @@ protected:
return; return;
} }
// Check if response indicates success // Check for error first, return early on failure
if (response->command.cmd_set == 0x00 && if (!(response->command.cmd_set == 0x00 &&
response->command.cmd_id == 0x04 && response->command.cmd_id == 0x04 &&
response->ret_code == 0x00) response->ret_code == 0x00))
{ {
// Set the appropriate pcloud data active state based on command type std::cerr << __func__ << ": Failed to enable pcloud data for dev "
context->setPcloudDataActiveState(); "(" << context->device.discoveredDevice.deviceIdentifier
context->callOriginalCallback(true); << ") @(" << context->device.discoveredDevice.ipAddr << "). "
<< "cmd_set: " << (int)response->command.cmd_set
<< ", cmd_id: " << (int)response->command.cmd_id
<< ", ret_code: " << (int)response->ret_code << "\n";
context->callOriginalCallbackWithFailure();
return; return;
} }
// If we get here, the command failed context->setPcloudDataActiveState();
context->callOriginalCallbackWithFailure(); context->callOriginalCallback(true);
} }
void cleanup() void cleanup()