LivoxProto1:enPcloudData: reorder success case here

This commit is contained in:
2025-10-24 01:46:08 -04:00
parent 2b8f6b6ad5
commit 4bfcdf37da
+13 -8
View File
@@ -1533,19 +1533,24 @@ protected:
return;
}
// Check if response indicates success
if (response->command.cmd_set == 0x00 &&
// Check for error first, return early on failure
if (!(response->command.cmd_set == 0x00 &&
response->command.cmd_id == 0x04 &&
response->ret_code == 0x00)
response->ret_code == 0x00))
{
// Set the appropriate pcloud data active state based on command type
context->setPcloudDataActiveState();
context->callOriginalCallback(true);
std::cerr << __func__ << ": Failed to enable pcloud data for dev "
"(" << context->device.discoveredDevice.deviceIdentifier
<< ") @(" << context->device.discoveredDevice.ipAddr << "). "
<< "cmd_set: " << (int)response->command.cmd_set
<< ", cmd_id: " << (int)response->command.cmd_id
<< ", ret_code: " << (int)response->ret_code << "\n";
context->callOriginalCallbackWithFailure();
return;
}
// If we get here, the command failed
context->callOriginalCallbackWithFailure();
context->setPcloudDataActiveState();
context->callOriginalCallback(true);
}
void cleanup()