hayodea/salmanoff
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Add LoadableLibraryManager and refactor StimBuffApiManager to use it.

Browse Source 
Centralize dlopen/search in LoadableLibraryManager so typed library managers
can share one loaded-shlib registry without duplicating load/unload logic.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Hayodea Hekol
2026-06-10 21:14:55 -04:00
parent 10234bc422
commit 7eda755c15
7 changed files with 418 additions and 241 deletions
Download Patch File Download Diff File Expand all files Collapse all files
smocore/deviceManager/deviceManager.cpp
+9 -6
View File
@@ -11,6 +11,7 @@
#include <deviceManager/deviceManager.h>
#include <deviceManager/deviceReattacher.h>
#include <stimBuffApis/stimBuffApiManager.h>
#include <loadableLib/loadableLibraryManager.h>
#include <marionette/marionette.h>
#include <marionette/marionetteThread.h>
#include <mind.h>
@@ -92,7 +93,7 @@ DeviceManager::attachStimBuffDeviceCReq(
auto &sbam = stim_buff::StimBuffApiManager::getInstance();
auto &lib = sbam.getStimBuffApiLibByApiName(spec->stimBuffApi);
if (lib.isBeingDestroyed.load())
if (lib.loadedSharedLibrary->isBeingDestroyed.load())
{
throw std::runtime_error(
std::string(__func__) + ": Library is being destroyed"
@@ -103,12 +104,13 @@ DeviceManager::attachStimBuffDeviceCReq(
{
throw std::runtime_error(
std::string(__func__) + ": attachDeviceCReq() is NULL "
"for library '" + lib.libraryPath + "'");
"for library '" + lib.loadedSharedLibrary->libraryPath + "'");
}
/* FIXME Locking here makes no sense. */
sscl::co::CoQutex::ReleaseHandle sbamGuard =
co_await sbam.s.lock.getAcquireInvocationAndSuspensionPolicy();
co_await sbam.s.lock
.getAcquireInvocationAndSuspensionPolicy();
sscl::co::CoQutex::ReleaseHandle libGuard =
co_await lib.s.lock.getAcquireInvocationAndSuspensionPolicy();
sbamGuard.release();
@@ -151,7 +153,7 @@ DeviceManager::detachStimBuffDeviceCReq(
auto &sbam = stim_buff::StimBuffApiManager::getInstance();
auto &lib = sbam.getStimBuffApiLibByApiName(spec->stimBuffApi);
if (lib.isBeingDestroyed.load())
if (lib.loadedSharedLibrary->isBeingDestroyed.load())
{
throw std::runtime_error(
std::string(__func__) + ": Library is being destroyed"
@@ -162,12 +164,13 @@ DeviceManager::detachStimBuffDeviceCReq(
{
throw std::runtime_error(
std::string(__func__) + ": detachDeviceCReq() is NULL "
"for library '" + lib.libraryPath + "'");
"for library '" + lib.loadedSharedLibrary->libraryPath + "'");
}
/* FIXME Locking here makes no sense. */
sscl::co::CoQutex::ReleaseHandle sbamGuard =
co_await sbam.s.lock.getAcquireInvocationAndSuspensionPolicy();
co_await sbam.s.lock
.getAcquireInvocationAndSuspensionPolicy();
sscl::co::CoQutex::ReleaseHandle libGuard =
co_await lib.s.lock.getAcquireInvocationAndSuspensionPolicy();
sbamGuard.release();