hayodea/salmanoff
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

LivoxGen1: Remove obsolete locking comment

Browse Source 
We have now implemented serialization for device at/detachment
This commit is contained in:
Hayodea Hekol
2025-10-01 11:28:59 -04:00
parent 1b29f0e521
commit abc11bc7fc
1 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
senseApis/livoxGen1/livoxGen1.cpp
-11
View File
@@ -263,11 +263,6 @@ extern "C" void livoxGen1_attachDeviceReq(
"not available"); "not available");
} }
/** FIXME:
* We should acquire a spinlock here to ensure that the device isn't added
* in the interim while the async op executes.
*/
for (const auto& dev : g_attachedDevices) for (const auto& dev : g_attachedDevices)
{ {
if (dev->discoveredDevice.deviceIdentifier == desc->deviceIdentifier) if (dev->discoveredDevice.deviceIdentifier == desc->deviceIdentifier)
@@ -368,12 +363,6 @@ extern "C" void livoxGen1_detachDeviceReq(
Callback<smo::sense_api::sal_mlo_detachDeviceReqCbFn> cb Callback<smo::sense_api::sal_mlo_detachDeviceReqCbFn> cb
) )
{ {
/** FIXME:
* We should acquire a spinlock here to ensure that iterator doesn't become
* invalid in the interim while the async op executes. In the meantime,
* we'll repeat the search in the callback.
*/
// Find and remove the device from our collection // Find and remove the device from our collection
auto it = std::find_if(g_attachedDevices.begin(), g_attachedDevices.end(), auto it = std::find_if(g_attachedDevices.begin(), g_attachedDevices.end(),
[&desc](const std::shared_ptr<livoxProto1::Device>& dev) { [&desc](const std::shared_ptr<livoxProto1::Device>& dev) {