From cc33b333d21c196369a1b551b64b13faad91d71d Mon Sep 17 00:00:00 2001 From: Hayodea Hakol Date: Tue, 9 Sep 2025 20:09:57 -0400 Subject: [PATCH] livoxProto1: Document potential bug --- commonLibs/livoxProto1/device.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/commonLibs/livoxProto1/device.cpp b/commonLibs/livoxProto1/device.cpp index 3a4f0f5..4157365 100644 --- a/commonLibs/livoxProto1/device.cpp +++ b/commonLibs/livoxProto1/device.cpp @@ -20,6 +20,17 @@ #include "protocol.h" #include "core.h" + +/** EXPLANATION: + * This file contains the implementation of the Device class. + * + * FIXME: + * We may need to check how smo-subnet-nbits is used in here because we didn't + * actually check to see under what conditions it's required vs optional. Hence + * we don't currently enforce correct usage of it, and we just assume that the + * livoxGen1's policy of supplying a default value of 24 is correct. + */ + namespace livoxProto1 { namespace comms {