From d75430ef82bc60f15e31b7256efd1de1e8fda4c9 Mon Sep 17 00:00:00 2001 From: Hayodea Hekol Date: Tue, 30 Sep 2025 21:25:58 -0400 Subject: [PATCH] Qutex: Document the need to deal with early release()s --- smocore/qutex.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/smocore/qutex.cpp b/smocore/qutex.cpp index d504c39..68f81af 100644 --- a/smocore/qutex.cpp +++ b/smocore/qutex.cpp @@ -296,6 +296,13 @@ void Qutex::release() lock.acquire(); isOwned = false; + /** FIXME: + * We need to be able to call this twice or more from the same request. + * We can either add further metadata to this class, or we can force all + * release() calls to be done via the Continuation object, such that it + * can ensure that it doesn't double-release any locks that were released + * early. + */ #ifdef CONFIG_ENABLE_DEBUG_LOCKS currOwner = nullptr; #endif