PuppetApp: Lifetime mgmt ops are now Viral

They no longer accept an exc_ptr and lambda for cb.

include/spinscale/puppetApplication.h

@@ -2,8 +2,6 @@
 #define PUPPET_APPLICATION_H
 
 #include <config.h>
-#include <exception>
-#include <functional>
 #include <memory>
 #include <string_view>
 #include <vector>
@@ -22,16 +20,11 @@ public:
 		const std::vector<std::shared_ptr<PuppetThread>> &threads);
 	~PuppetApplication() = default;
 
-	co::ViralNonPostingInvoker<void> joltAllPuppetThreadsCReq(
+	co::ViralNonPostingInvoker<void> joltAllPuppetThreadsCReq();
-		std::exception_ptr &exceptionPtr, std::function<void()> callback);
+	co::ViralNonPostingInvoker<void> startAllPuppetThreadsCReq();
-	co::ViralNonPostingInvoker<void> startAllPuppetThreadsCReq(
+	co::ViralNonPostingInvoker<void> pauseAllPuppetThreadsCReq();
-		std::exception_ptr &exceptionPtr, std::function<void()> callback);
+	co::ViralNonPostingInvoker<void> resumeAllPuppetThreadsCReq();
-	co::ViralNonPostingInvoker<void> pauseAllPuppetThreadsCReq(
+	co::ViralNonPostingInvoker<void> exitAllPuppetThreadsCReq();
-		std::exception_ptr &exceptionPtr, std::function<void()> callback);
-	co::ViralNonPostingInvoker<void> resumeAllPuppetThreadsCReq(
-		std::exception_ptr &exceptionPtr, std::function<void()> callback);
-	co::ViralNonPostingInvoker<void> exitAllPuppetThreadsCReq(
-		std::exception_ptr &exceptionPtr, std::function<void()> callback);
 
 	// CPU distribution method
 	void distributeAndPinThreadsAcrossCpus();
@@ -71,8 +64,6 @@ protected:
 
 private:
 	co::ViralNonPostingInvoker<void> allPuppetThreadsLifetimeOpCReq(
-		std::exception_ptr &exceptionPtr,
-		std::function<void()> callback,
 		PuppetThread::ThreadOp threadOp,
 		std::string_view emptyThreadsLogMessage);
 };

src/puppetApplication.cpp

@@ -63,9 +63,7 @@ void PuppetApplication::addAllPuppetLifetimeInvokersToGroup(
 }
 
 co::ViralNonPostingInvoker<void>
-PuppetApplication::joltAllPuppetThreadsCReq(
+PuppetApplication::joltAllPuppetThreadsCReq()
-	[[maybe_unused]] std::exception_ptr &exceptionPtr,
-	[[maybe_unused]] std::function<void()> callback)
 {
 	if (threadsHaveBeenJolted)
 	{
@@ -94,8 +92,6 @@ PuppetApplication::joltAllPuppetThreadsCReq(
 
 co::ViralNonPostingInvoker<void>
 PuppetApplication::allPuppetThreadsLifetimeOpCReq(
-	[[maybe_unused]] std::exception_ptr &exceptionPtr,
-	[[maybe_unused]] std::function<void()> callback,
 	PuppetThread::ThreadOp threadOp,
 	std::string_view emptyThreadsLogMessage)
 {
@@ -116,39 +112,31 @@ PuppetApplication::allPuppetThreadsLifetimeOpCReq(
 }
 
 co::ViralNonPostingInvoker<void>
-PuppetApplication::startAllPuppetThreadsCReq(
+PuppetApplication::startAllPuppetThreadsCReq()
-	std::exception_ptr &exceptionPtr, std::function<void()> callback)
 {
 	return allPuppetThreadsLifetimeOpCReq(
-		exceptionPtr, std::move(callback),
 		PuppetThread::ThreadOp::START,
 		noPuppetThreadsToStartLogMessage);
 }
 
 co::ViralNonPostingInvoker<void>
-PuppetApplication::pauseAllPuppetThreadsCReq(
+PuppetApplication::pauseAllPuppetThreadsCReq()
-	std::exception_ptr &exceptionPtr, std::function<void()> callback)
 {
 	return allPuppetThreadsLifetimeOpCReq(
-		exceptionPtr, std::move(callback),
 		PuppetThread::ThreadOp::PAUSE,
 		noPuppetThreadsToPauseLogMessage);
 }
 
 co::ViralNonPostingInvoker<void>
-PuppetApplication::resumeAllPuppetThreadsCReq(
+PuppetApplication::resumeAllPuppetThreadsCReq()
-	std::exception_ptr &exceptionPtr, std::function<void()> callback)
 {
 	return allPuppetThreadsLifetimeOpCReq(
-		exceptionPtr, std::move(callback),
 		PuppetThread::ThreadOp::RESUME,
 		noPuppetThreadsToResumeLogMessage);
 }
 
 co::ViralNonPostingInvoker<void>
-PuppetApplication::exitAllPuppetThreadsCReq(
+PuppetApplication::exitAllPuppetThreadsCReq()
-	std::exception_ptr &exceptionPtr,
-	std::function<void()> callback)
 {
 	if (componentThreads.empty())
 	{
@@ -157,7 +145,6 @@ PuppetApplication::exitAllPuppetThreadsCReq(
 	}
 
 	co_await allPuppetThreadsLifetimeOpCReq(
-		exceptionPtr, std::move(callback),
 		PuppetThread::ThreadOp::EXIT,
 		noPuppetThreadsToExitLogMessage);